Switch from deprecated 'header' hook to 'displayHeader' #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.xml
Outdated
| @@ -2,7 +2,7 @@ | |||
| <module> | |||
| <name>productcomments</name> | |||
| <displayName><![CDATA[Product Comments]]></displayName> | |||
| <version><![CDATA[5.0.1]]></version> | |||
| <version><![CDATA[5.0.2]]></version> | |||
There was a problem hiding this comment.
Suggested change
| <version><![CDATA[5.0.2]]></version> | |
| <version><![CDATA[5.0.1]]></version> |
productcomments.php
Outdated
| @@ -45,7 +45,7 @@ public function __construct() | |||
| { | |||
| $this->name = 'productcomments'; | |||
| $this->tab = 'front_office_features'; | |||
| $this->version = '5.0.1'; | |||
| $this->version = '5.0.2'; | |||
There was a problem hiding this comment.
Suggested change
| $this->version = '5.0.2'; | |
| $this->version = '5.0.1'; |
PierreRambaud
suggested changes
Dec 29, 2021
Ah, so it seems. I can add the hook upgrade there. |
|
btw, is there a best practice on registerhook / unregisterhook. which one should be done first? |
PierreRambaud
approved these changes
Dec 29, 2021
Nope, there is nothing related to it ^^ |
|
Thank you @tswfi |
PierreRambaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the version number should be increased in a PR like this or should there be another pr for it..