Update list-comments.js

[djbuch]

Questions	Answers
Description?	Correct a bug, where stars on additionnal products on a product page would have wrong star number, because the stars where inited before the grade retrivial
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	View a product page with additionnal products having comments, without this correction they would alwas have only one star.

[kpodemski]

Hi @djbuch

Good to see you again in the project! Have you tried to do something like:

setTimeout(function() {
    $('.grade-stars').rating();
}, 0);

maybe that would help with the issues you have. otherwise, it's hard for me to understand why your code would be different if we target the same selectors, eventually

[djbuch]

Hello, we are not targeting the same selectors, in fact I added a more specific selector before, in order to avoid to target all .grade-stars Regards, Le jeu. 25 mai 2023 à 14:42, Krystian Podemski ***@***.***> a écrit :

…

Hi @djbuch <https://github.com/djbuch> Good to see you again in the project! Have you tried to do something like: setTimeout(function() { $('.grade-stars').rating(); }, 0); maybe that would help with the issues you have. otherwise, it's hard for me to understand why your code would be different if we target the same selectors, eventually — Reply to this email directly, view it on GitHub <#163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLAMXABCT4D3ICLRMVGBQDXH5HVDANCNFSM6AAAAAAYOQISMM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[SharakPL]

Hi @djbuch
Can you link an issue to be fixed by this PR or at least provide detailed info here? QA needs to know exactly what is it fixing to check if it's valid.

[djbuch]

Hello,
I'm sorry but quite a year after this issue I don't remember what raised the problem on my side.

Nevertheless I remember it was the only way to correct this bug effectively. It is never a good idea to use to large selectors, as other module can need to init rating(), and sometimes on an async basis.

Regards,

[SharakPL]

I'm guessing it's for the product page where you have .grade-stars of the main product, but it's the same class for any product list item with rating so whenever a product page includes eg. accessories, crossselling module or same category products then all of them may have individual .grade-stars elements. We have to make sure only the one belonging to the main product changes. Is that right?

Although this main rating on the product page may be in several places so we might need further changes to cover all of them.