Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing previous module files in PHPStan tests #187

Merged
merged 1 commit into from Sep 15, 2023
Merged

Fix removing previous module files in PHPStan tests #187

merged 1 commit into from Sep 15, 2023

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? The previous way of removing the directory didn't work correctly.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? This is just a copy of PrestaShop/blockreassurance#594
How to test? CI is 馃煝 (with less random php-test rm -rf failures :)

@kpodemski kpodemski merged commit 799da9d into PrestaShop:dev Sep 15, 2023
8 checks passed
@kpodemski
Copy link
Contributor

thanks @leemyongpakvn :D

@leemyongpakvn leemyongpakvn added this to the 6.0.3 milestone Nov 17, 2023
@leemyongpakvn leemyongpakvn deleted the improved-phpstan-script branch January 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
6.0.3
2 participants
@leemyongpakvn @kpodemski