Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 5 stars default #196

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Set 5 stars default #196

wants to merge 1 commit into from

Conversation

alfonsolr09
Copy link

@alfonsolr09 alfonsolr09 commented Jan 12, 2024

Customers do not usually modify the stars since they go unnoticed. I have a store with reviews from very happy customers and they all leave 3 stars because they don't see what comes predefined

Questions Answers
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/Prestashop#{issue number here}.
How to test? Please indicate how to best verify that this PR is correct.

Customers do not usually modify the stars since they go unnoticed.
I have a store with reviews from very happy customers and they all leave 3 stars because they don't see what comes predefined
@alfonsolr09
Copy link
Author

Another solution would be to not set anything by default and if the client sends the form without marking any stars, an error message appears

@Hlavtox wdyt?

@leemyongpakvn
Copy link
Contributor

leemyongpakvn commented Jan 13, 2024

We already have a suggestion to Make rating mandatory but no one implement it yet ;)
I'd prefer a Configurable default rating to a Fixed value one.

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely can't merge this without consulting the product team (@PrestaShop/product-council @MatShir )

@fabienvallon
Copy link

We definitely can't merge this without consulting the product team (@PrestaShop/product-council @MatShir )

I think make rating mandatory is the good choice.
Waiting for PR / contribution :)

@alfonsolr09
Copy link
Author

I think no. For the merchant, it is better that the 5-star option comes predefined.

The customer who wants to leave a negative review will be careful to select 1 star.

@RosaBenouamer
Copy link

I agree with @fabienvallon.
I share your opinion @alfonsolr09 that's a problem that the merchant is penalized.
But as the problem is "Customers do not usually modify the stars since they go unnoticed."
This PR doesn't completely resolve the issue. Indeed still have 5 is not a good thing too.
It could be better making the rating mandatory like this the client will really be aware of his rate.

@matthieu-rolland
Copy link
Contributor

I agree with @fabienvallon. I share your opinion @alfonsolr09 that's a problem that the merchant is penalized. But as the problem is "Customers do not usually modify the stars since they go unnoticed." This PR doesn't completely resolve the issue. Indeed still have 5 is not a good thing too. It could be better making the rating mandatory like this the client will really be aware of his rate.

should this be specified somewhere or can this modification be made in this PR and merged directly after qa tests ?

@alfonsolr09
Copy link
Author

This pr could be merged for now as a provisional improvement. Since we do not have a forecast date for someone to make the other improvement.

1 similar comment
@alfonsolr09
Copy link
Author

This pr could be merged for now as a provisional improvement. Since we do not have a forecast date for someone to make the other improvement.

@RosaBenouamer
Copy link

@fabienvallon if it's ok for you it's ok for me too. It make sens :-)

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr could be merged for now as a provisional improvement. Since we do not have a forecast date for someone to make the other improvement.

I'm not even sure this is legal (to have customer push a 5 stars review without him having chosen a specific score) 🤔

@fabienvallon and @RosaBenouamer (product team) have decided that instead the rating should be mandatory, @alfonsolr09 do you think it's a modification you could make in this pull request ?

@alfonsolr09
Copy link
Author

I don't think I'm qualified to do that job. In relation to legality issues, before you marked 3 stars by default, what is the problem that now the default is 5?

1 similar comment
@alfonsolr09
Copy link
Author

I don't think I'm qualified to do that job. In relation to legality issues, before you marked 3 stars by default, what is the problem that now the default is 5?

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm qualified to do that job. In relation to legality issues, before you marked 3 stars by default, what is the problem that now the default is 5?

well 3 is average, 5 is maximum... but in both cases it's weird.

There's now a pull request to make the rating mandatory 👍
#197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
6 participants