Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force installation in all stores context #58

Merged
merged 1 commit into from Jul 21, 2020

Conversation

kpodemski
Copy link
Contributor

@kpodemski kpodemski commented Jun 18, 2020

This is related to this issue:
PrestaShop/PrestaShop#19811

If you never had productomments in your store, and you'll install module in context of only second store, you'll have troubles with messed up configuration, for example some options will only be read from context of All stores at first

Steps to test:

  1. multi-store enabled with at least two stores First and Second
  2. go to "Second" store context, install productcomments
  3. enable comments for non logged-in users in second store
  4. check if you can add a new comment as a non logged-in user, you can't
  5. now go to "All stores", set all settings (because they're empty which is wrong), you want to enable comments for non logged-in users
  6. now if you go to Second store product page, you can add a comment for a non logged-in user
  7. now go to Second store comments configuration and turn off comments for guests, as you can see now you can do that

Overall - in my opinion - it is a good practice to install in the context of all stores in most scenarios

btw. i really hope y'all start to treat multi-store feature more seriously, my biggest customers depends on it, if you want help, consultation or something, i'm available

Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine

@kpodemski If I remember right, there is an EPIC issue in order to work on multishop features to improve it, I seen some front-end works (my part) on it, but don't hesitate to create some issues when needed !

@Progi1984 Progi1984 merged commit e516425 into PrestaShop:dev Jul 21, 2020
@Progi1984
Copy link
Contributor

Thanks @kpodemski & @sarahdib

@matks matks added the bug label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants