Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully skip github info requests when the token has not been set #44

Merged
merged 1 commit into from Sep 12, 2023

Conversation

eternoendless
Copy link
Member

Questions Answers
Description? This change makes it so that when the access token environment variable has not been set, it will skip github requests and issue a warning (which makes for faster rendering when run locally). I've also moved the footer to a partial of its own and improved the code a little.
Type? improvement
Sponsor company PrestaShop SA

Screenshot 2023-08-22 at 16 52 31

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge whenever ready for docs deploy 👍

@eternoendless
Copy link
Member Author

Thanks for the review!

@eternoendless eternoendless merged commit 275bead into PrestaShop:main Sep 12, 2023
@eternoendless eternoendless deleted the fix-git-info branch September 12, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants