Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GH Action to test generate on PRs #19

Merged
merged 1 commit into from Jan 18, 2023
Merged

Add GH Action to test generate on PRs #19

merged 1 commit into from Jan 18, 2023

Conversation

matks
Copy link
Contributor

@matks matks commented Jan 15, 2023

Questions Answers
Description? Add GH Action to test generate on PRs. If a Pull Request is submitted and breaks generate.php this CI workflow will block the contribution.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? CI should be green
Possible impacts?

@matks matks mentioned this pull request Jan 15, 2023
Closed
@matks
Copy link
Contributor Author

matks commented Jan 15, 2023

The GH action works as demonstrated by PR #20 which is blocked because I introduced an error inside generate.php

@matks matks merged commit e5df175 into PrestaShop:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox approved these changes

@mflasquin mflasquin mflasquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matks @Hlavtox @mflasquin