Adapt ps_crossselling for multiples versions of PrestaShop
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hlavtox
approved these changes
Feb 3, 2023
nicosomb
approved these changes
Feb 6, 2023
HanaRebaiQA
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Hello @Progi1984
I have checked your PR.
Check on PS1733 : OK
Check on PS8.0.1 : OK
Check with multistore: OK
Check with different php versions (php7.1 and php8.1) : OK
So, it's QA ✔️
Thank You!
HanaRebaiQA
added
QA ✔️
and removed
waiting for QA
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps_crosssellingfor multiples versions of PrestaShop< 1.7.4.0and in recent version (8.0.0)