Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to undefined function #20

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

davidglezz
Copy link
Contributor

Fix PrestaShop/PrestaShop#12553

The function removeMyAccountBlockHook() does not exist in all prestashop codebase or in this module.

This line may be inherited from previous versions or beta versions.

Dev branch are outdated.

Fix PrestaShop/PrestaShop#12553

The function removeMyAccountBlockHook() does not exist in all prestashop codebase or in this module.

This line may be inherited from previous versions or beta versions.
PierreRambaud
PierreRambaud previously approved these changes Sep 2, 2019
@davidglezz
Copy link
Contributor Author

What do we do with this?

@PierreRambaud PierreRambaud added the waiting for QA Status: Waiting for QA feedback label Jan 29, 2020
@PierreRambaud PierreRambaud dismissed their stale review January 29, 2020 10:01

The base branch was changed.

@PierreRambaud PierreRambaud changed the base branch from master to dev January 29, 2020 10:01
@PierreRambaud
Copy link
Contributor

@davidglezz My bad, forget to add the Waiting for QA label and change the target branch.

@SD1982 SD1982 self-assigned this Feb 10, 2020
@SD1982
Copy link

SD1982 commented Feb 12, 2020

the pull request correctly fix the bug
fix to call to undifined function after pr
thanks @davidglezz

@SD1982 SD1982 added QA ✔️ and removed waiting for QA Status: Waiting for QA feedback labels Feb 12, 2020
@PierreRambaud PierreRambaud merged commit 9708ba8 into PrestaShop:dev Feb 12, 2020
@PierreRambaud
Copy link
Contributor

Thanks @davidglezz

@PierreRambaud PierreRambaud added this to the 3.1.1 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants