Implement call to hook filterHtmlContent on modules HTML #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progi1984
reviewed
Jan 6, 2021
|
Not clear if action is required from me? Changes proposed by @Progi1984 are fine by me so I set Resolved. Do I need to include changes in my code or will they run through in due time? |
|
@elburgl69 I don't see your changes. Have you pushed modifications ? |
|
Did it right now. Was not sure if I had to push your suggested changes. |
|
@elburgl69 Sorry, but I don't see your changes in Github interface : https://github.com/PrestaShop/ps_customtext/pull/53/files |
elburgl69
force-pushed
the
dev
branch
2 times, most recently
from
f2c69fc
to
6994ef7
Compare
Progi1984
reviewed
Jan 7, 2021
Progi1984
approved these changes
Jan 7, 2021
|
@elburgl69 Could you fix Github Checks, please ? |
elburgl69
force-pushed
the
dev
branch
2 times, most recently
from
23bd4ca
to
0a049f4
Compare
|
Done |
PierreRambaud
previously requested changes
Jan 7, 2021
elburgl69
force-pushed
the
dev
branch
2 times, most recently
from
274a206
to
18ce6a1
Compare
matthieu-rolland
approved these changes
Feb 15, 2021
matthieu-rolland
dismissed
PierreRambaud’s stale review
all checks are green now
|
Hi @elburgl69, It is ok ✔️ With PR Thank you! |
|
Thanks @elburgl69 & @khouloudbelguith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates ps_customtext in such way that the HTML of this module is treated as any other prestashop HTML, so that hook filterHTMLContent is called also,
This change is