Bump min compatibility to PHP 7.1.3 and PS 1.7.7, module version to 3.0.0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leemyongpakvn
commented
Sep 28, 2023
•
leemyongpakvn
commented
| Questions | Answers |
|---|---|
| Description? | Please check the related issue. |
| Type? | improvement |
| BC breaks? | Does it break backward compatibility? yes |
| Deprecations? | Does it deprecate an existing feature? no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#32841 |
| How to test? | CI 馃煝. Module works as usual on PS 1.7.7 and newer versions. |
leemyongpakvn
changed the title
|
@kpodemski We still face |
|
@leemyongpakvn this time it's different I think 馃 it looks like it has been deleted, and we try to remove something that doesn't exist |
leemyongpakvn
changed the title
kpodemski
reviewed
Oct 3, 2023
Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
|
@leemyongpakvn ok I see we need some improvements to the removal script 馃檮 |
kpodemski
reviewed
Oct 3, 2023
Let's try Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
kpodemski
approved these changes
Oct 4, 2023
|
thank you @leemyongpakvn - since it has no functional changes, I'm merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.