Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move php-dev-tools to require-dev #98

Merged
merged 1 commit into from Jan 5, 2022
Merged

Move php-dev-tools to require-dev #98

merged 1 commit into from Jan 5, 2022

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Jan 4, 2022

Questions Answers
Description? because prestashop/php-dev-tools was not in the require-dev dependencies, it was taken into account when trying to require it on PrestaShop 8.0, but the php compatibility was causing an issue. This PR solves the issue by putting prestashop/php-dev-tools in the require-dev dependencies.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27037
How to test? No test needed?

@atomiix atomiix added this to the 2.3.1 milestone Jan 4, 2022
@PierreRambaud PierreRambaud merged commit 006933b into PrestaShop:dev Jan 5, 2022
@PierreRambaud
Copy link
Contributor

Thank you @atomiix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.3.1
2 participants
@atomiix @PierreRambaud