Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring values sorting #124

Merged
merged 6 commits into from Aug 29, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Aug 19, 2019

  • Only sort by magnitude if there is a filters show limitations
  • Do not sort attributes by label

Fixes: PrestaShop/PrestaShop#15065
PrestaShop/PrestaShop#14989

Specs:
https://github.com/PrestaShop/prestashop-specs/blob/master/ps_facetedsearch.md#sorting


This change is Reviewable

- Only sort by magnitude if there is a filters show limitations
- Do not sort attributes by names
@PierreRambaud PierreRambaud added this to the 3.2.1 milestone Aug 19, 2019
@PierreRambaud PierreRambaud changed the base branch from master to dev Aug 19, 2019
@matks
matks approved these changes Aug 20, 2019
@sarahdib sarahdib self-assigned this Aug 29, 2019
@sarahdib sarahdib added QA approved and removed Waiting for QA labels Aug 29, 2019
@PierreRambaud PierreRambaud merged commit 30d4a62 into PrestaShop:dev Aug 29, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:filters-sorting branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.