Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX improvement - scroll to #products container on updateProductList event #131

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Sep 3, 2019

Scroll to #products container on updateProductList event.

Works fine as standalone feature - probably need to be fixed in this code (im not jq expert - just shark ;-) )

Cheers!


This change is Reviewable

Scroll to #products container on updateProductList event. Works fine as standalone feature - probably need to be fixed in this code.
@ghost
Copy link
Author

ghost commented Sep 6, 2019

One flaw. Might be anoying when user want to select few combinations at once (like color, size). In that case when user check desired combinations then search button should be available to fire up search event.

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Sep 6, 2019

@PrestaShark I think this is one reason why they told me to let the theme do this job.
More because the page can be changed in different way (buttons, nav, links, ..)
Not sure this one can be integrate directly in the module.

Wdyt @marionf @colinegin

(If yes, the PR'll be updated because we can't update assets manually :D )

@marionf
Copy link
Contributor

marionf commented Sep 10, 2019

Hello @PrestaShark

As you can see, we already talked about this here:

PrestaShop/PrestaShop#10993
PrestaShop/PrestaShop#14740

And we don't want to change this behavior for the reasons explained in these issues, especially:

This is something each individual shop owner and / or theme should be in control of and not the core platform nor facetedsearch module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants