New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use hook alias - follow-up, bump version to 2.1.1 #40
Conversation
SharakPL
commented
Nov 15, 2021
•
edited
edited
Questions | Answers |
---|---|
Description? | Follow-up of PrestaShop/ps_mainmenu#56 and PrestaShop/PrestaShop#26601 |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | - |
How to test? | No need QA |
@PierreRambaud sorry about that 😳 Just small rearrangement. |
PHP CS fixer is still not happy 😅 |
Should be good now. #34 left some unwanted spaces 😉 |
Hi @SharakPL, @Progi1984,
We don't need QA to test this PR? If not, @SharakPL, can you create a new issue to describe the steps to reproduce the issue? Thank you! |
Yes, QA is not needed here |
I was just following PR specs from PrestaShop/ps_mainmenu#56 (changes are all the same except version numbers). |
@PierreRambaud thanks for your feedback. Thanks! |
Thank you @SharakPL |