Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use hook alias - follow-up, bump version to 2.1.1 #40

Merged
merged 3 commits into from Nov 23, 2021

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Nov 15, 2021

Questions Answers
Description? Follow-up of PrestaShop/ps_mainmenu#56 and PrestaShop/PrestaShop#26601
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? No need QA

@SharakPL SharakPL changed the title Do not use hook alias - follow-up Do not use hook alias - follow-up, bump version to 2.1.1 Nov 15, 2021
PierreRambaud
PierreRambaud previously approved these changes Nov 15, 2021
@SharakPL
Copy link
Contributor Author

@PierreRambaud sorry about that 😳 Just small rearrangement.

@PierreRambaud
Copy link
Contributor

PHP CS fixer is still not happy 😅

@SharakPL
Copy link
Contributor Author

Should be good now. #34 left some unwanted spaces 😉

@Progi1984 Progi1984 added the waiting for QA Status: Waiting for QA feedback label Nov 19, 2021
@Progi1984 Progi1984 added this to the 2.1.1 milestone Nov 19, 2021
@khouloudbelguith
Copy link

Hi @SharakPL, @Progi1984,

No need QA

We don't need QA to test this PR?

If not, @SharakPL, can you create a new issue to describe the steps to reproduce the issue?

Thank you!

@PierreRambaud
Copy link
Contributor

Hi @SharakPL, @Progi1984,

No need QA

We don't need QA to test this PR?

If not, @SharakPL, can you create a new issue to describe the steps to reproduce the issue?

Thank you!

Yes, QA is not needed here

@SharakPL
Copy link
Contributor Author

SharakPL commented Nov 22, 2021

I was just following PR specs from PrestaShop/ps_mainmenu#56 (changes are all the same except version numbers).
I didn't even know what QA means at the time. I thought it's something with questions and answers 😂 Never would have guessed it's Quality Assurance!

@khouloudbelguith
Copy link

Hi @SharakPL, @Progi1984,

No need QA

We don't need QA to test this PR?
If not, @SharakPL, can you create a new issue to describe the steps to reproduce the issue?
Thank you!

Yes, QA is not needed here

@PierreRambaud thanks for your feedback.
Can you please remove the Waiting for QA label?

Thanks!

@PierreRambaud PierreRambaud removed the waiting for QA Status: Waiting for QA feedback label Nov 23, 2021
@PierreRambaud PierreRambaud merged commit e746524 into PrestaShop:dev Nov 23, 2021
@PierreRambaud
Copy link
Contributor

Thank you @SharakPL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants