Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translations #128

Merged
merged 1 commit into from Dec 9, 2022
Merged

Fix translations #128

merged 1 commit into from Dec 9, 2022

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Dec 7, 2022 •
edited by hibatallahAouadni

Questions Answers
Description? Fix translations
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#30008
How to test? Please see PrestaShop/PrestaShop#30008
Possible impacts?

@atomiix atomiix mentioned this pull request Dec 7, 2022
Merged
@AureRita AureRita self-assigned this Dec 8, 2022
AureRita
AureRita approved these changes Dec 8, 2022
View reviewed changes
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atomiix

Thank you for your PR, I tested it and it works, as we can see here :

image

image

We can see on the last screen that we need two other dot at the end of the successfull message but it's not on the issue so it's QA Approved

@nicosomb nicosomb merged commit c8e2f17 into PrestaShop:dev Dec 9, 2022
@nicosomb
Copy link
Contributor

nicosomb commented Dec 9, 2022

Thank you @atomiix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@AureRita AureRita AureRita approved these changes

Assignees

@AureRita AureRita

Labels
QA ✔️
Projects
None yet
Milestone
No milestone
4 participants
@atomiix @nicosomb @kpodemski @AureRita