Fix wrong templates used on product page columns

[jsuzineau]

Questions	Answers
Description?	This fix will make correct module templates to be used in product columns.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#30802
How to test?	Prestashop 1.7.8, Theme Classic 1.0.0, ps_linklist 5.0.5. Check FO product page

[SharakPL]

Hi @jsuzineau.
Thanks for the PR and sorry for the delay.

Small improvements needed and we're good to go :)

BTW could you also make a small refactor on line 146 and move lonely ; to the end of line 145?

ps_linklist/ps_linklist.php

Lines 142 to 146 in 564b2b5

	$dataLoadedWithSuccess = $dataLoadedWithSuccess
	&& $this->registerHook('displayFooter')
	&& $this->registerHook('actionUpdateLangAfter')
	&& $this->registerHook('actionGeneralPageSave')
	;

It should look like this:

        $dataLoadedWithSuccess = $dataLoadedWithSuccess
            && $this->registerHook('displayFooter')
            && $this->registerHook('actionUpdateLangAfter')
            && $this->registerHook('actionGeneralPageSave');

CS

[jsuzineau]

Hello,  I'm a complete newbie to pull requests and I'm wondering what I'm supposed to do now ? I saw you commited several corrections to the pull request branch. Should I update the pull request branch from the main dev branch ? Is it up to me to propose the merge of the pull request branch to the main dev branch ? Yours sincerely, Jean SUZINEAU Le 12/01/2023 à 20:16, Tom Zajac a écrit :

…

***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#155 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJANJLGXUW6XAN2VCHLNLDWSBKADANCNFSM6AAAAAARLE44JM>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Hlavtox]

@jsuzineau All is good now. Now a QA tester will test it. If everything is fine, he will put "QA ✅" label and we will merge it. 👍

[SharakPL]

Hi @jsuzineau. I noticed you're not really active on GitHub appart from this single PR. I wasn't sure if you'll be able to finish it so I did refactoring myself. If you want to update your repo locally just use git pull command, but you don't need to since the work here is over. Now we only await final approval from QA team to be able to merge it into the main repo. After that your branch process_displayLeftColumnProduct won't be needed anymore and you'll be free to delete it.

Thanks for pointing out the problem with the column templates.

[MhiriFaten]

Hello @jsuzineau ,

I have checked your PR and the wrong templates were used on product page columns are fixed, but the touchspin button is misplaced !

Could you check it please?

Waiting for your feedback !
Thank you 😄

[SharakPL]

Thanks @MhiriFaten for your feedback.
The bug with the quantity form needs to be fixed in another PR in classic theme repo. Since you confirmed the bug with the module templates is fixed by this PR I'll let myself to add proper QA label and merge it.

[Hlavtox]

@MhiriFaten The behavior is because of two columns together, which is so old school that nobody tests it. :-) The same behavior is without this module.