Remove language from filter #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Prestaworks
commented
Feb 6, 2024
Prestaworks
commented
| Questions | Answers |
|---|---|
| Description? | Fix for issue 35275 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#35275. |
| How to test? | Follow instructions in ticket. |
Prestaworks
force-pushed
the
issue_35275
branch
from
1e418b4
to
fd2b351
Compare
boherm
approved these changes
Feb 7, 2024
florine2623
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for the PR @Prestaworks ,
Screen.Recording.2024-02-08.at.17.08.52.mov
Tested with multiple languages, multishop and multiple group.
Tested with links that are present in multiple blocks.
LGTM 💪
It is QA ✅
|
Thanks @Prestaworks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.