Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate error on install #194

Merged
merged 1 commit into from Feb 15, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Feb 13, 2024

Questions Answers
Description? Remove duplicate execution of the request to prevent duplicate errors from DB on install
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Run composer create-test-db on develop or 8.1.x branch from the core One time out of two the install fails because of a duplicate error from the DB, with this branch fix the problem is gone

@jolelievre jolelievre modified the milestones: 6.0.5, 6.0.6 Feb 13, 2024
@M0rgan01
Copy link
Contributor

After several rounds of local integration testing, no more duplication errors.

@M0rgan01 M0rgan01 added the QA ✔️ Status: QA-Approved label Feb 15, 2024
@M0rgan01 M0rgan01 merged commit 17c2144 into PrestaShop:dev Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants