Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grid count invalid with multiple languages #197

Merged
merged 2 commits into from Feb 28, 2024
Merged

Fix grid count invalid with multiple languages #197

merged 2 commits into from Feb 28, 2024

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Description? Fix grid builder count query, we must count DISTINCT IDs now because multilang data is returned by the query
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Go to Design > Link list, before this PR the count is doubled (well if you have two languages installed, if you have three it will likely be tripled, ...) ith the fix the count is correct regardless of the number of languages installed

@jolelievre jolelievre added this to the 6.0.7 milestone Feb 28, 2024
@jolelievre jolelievre changed the title Fix grid count Fix grid count invalid with multiple languages Feb 28, 2024
florine2623
florine2623 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jolelievre ,

Tested on 8.1.x and develop.

LGTM ✅

  • Tested with multilangages
  • CRUD blocks
  • Checked before/after disabling/adding languages
  • Deleted blocks, updated count is correct.

Before:
Screenshot 2024-02-28 at 14 12 26

After:
Screenshot 2024-02-28 at 14 12 32

Thanks!

@florine2623 florine2623 self-assigned this Feb 28, 2024
@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed Waiting for QA labels Feb 28, 2024
@matthieu-rolland
Copy link
Contributor

thank you @jolelievre and @florine2623 !

@matthieu-rolland matthieu-rolland merged commit eb2a0dd into PrestaShop:dev Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️ Status: QA-Approved
Projects
PR Dashboard
Archived in project
Milestone
6.0.7
4 participants
@jolelievre @matthieu-rolland @florine2623 @ps-jarvis