Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

BO ps_reminder emails translations #20

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

bm-services
Copy link

@bm-services bm-services commented Apr 2, 2019

Fixed issue #9585 - BOOM-5975

@yannicka
Copy link

Could this PR be merged?

@PierreRambaud
Copy link

This PR needs to be rebased (sorry for the delay)

@Progi1984
Copy link

Hello @bm-services, thanks for your contribution, would you mind to rebase your pull request? Thanks

Copy link

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Some rights seems to be changed. Could you revert this rights changes ? Thanks

@LouiseBonnard
Copy link

Is it still the case with the recently introduced modern email template?

@LouiseBonnard
Copy link

Actually, I would even add more explicit information (make the name of the email match the configuration settings) while working on it:

followup_1 would give canceled_cart in ps_reminder
followup_2 would give reorder in ps_reminder
followup_3 would give best_customer in ps_reminder
followup_4 would give bad_customer in ps_reminder

@Progi1984, could it introduce a breaking change?

@Progi1984
Copy link

@PrestaShop/prestashop-core-developers Need your help for answering to @LouiseBonnard

Copy link

@quentic quentic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in ps_reminder.php, the variable cron_url needs to be declared before it can be used

@bm-services
Copy link
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants