Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade 2.1.1 file #88

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

ga-devfront
Copy link
Contributor

Questions Answers
Description? This may seem silly, but having a line before the PhP tag is sometimes poorly managed by module upgrades. We can therefore end up with an error like this:PHP Fatal error: Uncaught RuntimeException: Failed to start the session because headers have already been sent by "/var/www/html/modules/ps_wirepayment/upgrade/upgrade-2.1.1.php" at line 1. in /var/www/html/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php:150
Type? bug fix
BC breaks? no
Deprecations? no
How to test? You can try update then this PR is merged and another zip is created

@ps-jarvis
Copy link

Hello @ga-devfront!

This is your first pull request on ps_wirepayment repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Jun 19, 2024
@boherm
Copy link
Member

boherm commented Jun 19, 2024

Nice! Thanks @ga-devfront!

@Hlavtox
Copy link
Contributor

Hlavtox commented Jun 19, 2024

@ga-devfront Good find, I made a quick search now... :D

pagesnotfound\upgrade\upgrade-2.0.2.php
ps_wirepayment\upgrade\upgrade-2.1.1.php
statsbestcategories\upgrade\upgrade-2.0.1.php
statsbestcustomers\upgrade\upgrade-2.0.4.php
statsbestmanufacturers\upgrade\upgrade-2.0.1.php
statsbestproducts\upgrade\upgrade-2.0.1.php
statsbestsuppliers\upgrade\upgrade-2.0.1.php
statsbestvouchers\upgrade\upgrade-2.0.1.php
statscarrier\upgrade\upgrade-2.0.1.php
statscatalog\upgrade\upgrade-2.0.2.php
statsforecast\upgrade\upgrade-2.0.4.php
statscheckup\upgrade\upgrade-2.0.2.php
statsnewsletter\upgrade\upgrade-2.0.3.php
statspersonalinfos\upgrade\upgrade-2.0.4.php
statsproduct\upgrade\upgrade-2.1.1.php
statsregistrations\upgrade\upgrade-2.0.1.php
statssales\upgrade\upgrade-2.1.0.php
statssearch\upgrade\upgrade-2.0.2.php
statsstock\upgrade\upgrade-2.0.1.php

@Hlavtox Hlavtox merged commit d56f28c into PrestaShop:dev Jun 19, 2024
8 checks passed
@Hlavtox Hlavtox removed the waiting for QA Status: Waiting for QA feedback label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants