Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions #25

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Remove deprecated functions #25

merged 1 commit into from
Apr 15, 2022

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Mar 29, 2022

Questions Answers
Description? Remove deprecated functions so the module works without jQuery migrate.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#28069
How to test? Check that data still come in.

Ping @NeOMakinG

Progi1984
Progi1984 previously approved these changes Mar 30, 2022
View reviewed changes
kpodemski
kpodemski previously approved these changes Mar 30, 2022
View reviewed changes
NeOMakinG
NeOMakinG previously approved these changes Mar 30, 2022
View reviewed changes
@kpodemski
Copy link
Contributor

Hey @Hlavtox

There's a conflict because othe contibutor introduced the code changing unload to something more reliable in other PR. Could you check if your changes are still relevant?

ps: contact me on Slack, please :D

@Hlavtox Hlavtox dismissed stale reviews from NeOMakinG, kpodemski, and Progi1984 via b1ebd59 March 30, 2022 19:39
@Progi1984 Progi1984 added this to the 2.1.1 milestone Apr 4, 2022
@hibatallahAouadni hibatallahAouadni self-assigned this Apr 12, 2022
szavadskiy
szavadskiy approved these changes Apr 15, 2022
View reviewed changes
Copy link

@szavadskiy szavadskiy left a comment •
edited by hibatallahAouadni
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Hlavtox
Its LGTM, after installing your PR I didn't find an error in the console.
Thank you for your PR. 🚀

hibatallahAouadni
hibatallahAouadni approved these changes Apr 15, 2022
View reviewed changes
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

Thanks for your PR, LGTM and QA ✔️
And thanks @szavadskiy for testing the PR 👏

Thanks!

@Progi1984 Progi1984 merged commit cd6d968 into PrestaShop:dev Apr 15, 2022
@Progi1984
Copy link
Contributor

Thanks @Hlavtox & @hibatallahAouadni

@Robin-Fischer-PS
Copy link

And thanks a lot @szavadskiy ! Congrats for your first PR tested 🎉

@Progi1984
Copy link
Contributor

Sorry @szavadskiy : Big Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

@szavadskiy szavadskiy szavadskiy approved these changes

@kpodemski kpodemski kpodemski left review comments

@NeOMakinG NeOMakinG NeOMakinG left review comments

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️
Projects
None yet
Milestone
2.1.1
9 participants
@Hlavtox @kpodemski @Progi1984 @Robin-Fischer-PS @PierreRambaud @matks @NeOMakinG @hibatallahAouadni @szavadskiy