This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
[+] MO: Add new field: block_class #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progi1984
approved these changes
May 13, 2020
|
Hi and thanks for your contribution. This repository is now deprecated. Sorry for the late answer 😞 Kind regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically, this module is very awkward to use in themes, because we have no controler over the block sizes. The template puts either
col-xs-12orcol-xs-4.Now this extra field (
block_class) would potentially make this a great module for theme developers, allowing the to specify the block width in theblock_classfield. We could upload one image and have it as a banner (col-xs-12), or we could have 2, have 3 or any number of blocks in the same.row. The potential extends futher, since we can enter HTML for each block and use classes to style them up.I made the upgrade file, but you may want to change the version number.