Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved POM @pages\BO\modules\ps_facetedsearch from Core #61

Merged

Conversation

Progi1984
Copy link
Contributor

Questions Answers
Branch? develop
Description? Moved POM @pages\BO\modules\ps_facetedsearch from Core
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI is 🟢
UI Tests
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company @PrestaShopCorp

import {ModuleConfigurationPageInterface} from '@interfaces/BO/modules/moduleConfiguration';
import {Page} from '@playwright/test';

export interface ModulePsFacetesearchFilterTemplatePageInterface extends ModuleConfigurationPageInterface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface ModulePsFacetesearchFilterTemplatePageInterface extends ModuleConfigurationPageInterface {
export interface ModulePsFacetedSearchFilterTemplatePageInterface extends ModuleConfigurationPageInterface {

import {ModuleConfigurationPageInterface} from '@interfaces/BO/modules/moduleConfiguration';
import {Page} from '@playwright/test';

export interface ModulePsFacetesearchMainPageInterface extends ModuleConfigurationPageInterface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface ModulePsFacetesearchMainPageInterface extends ModuleConfigurationPageInterface {
export interface ModulePsFacetedSearchMainPageInterface extends ModuleConfigurationPageInterface {

@@ -0,0 +1,9 @@
import type {ModulePsFacetesearchFilterTemplatePageInterface} from '@interfaces/BO/modules/ps_facetedsearch/filterTemplate';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import type {ModulePsFacetesearchFilterTemplatePageInterface} from '@interfaces/BO/modules/ps_facetedsearch/filterTemplate';
import type {ModulePsFacetedSearchFilterTemplatePageInterface} from '@interfaces/BO/modules/ps_facetedsearch/filterTemplate';

@@ -0,0 +1,9 @@
import type {ModulePsFacetesearchMainPageInterface} from '@interfaces/BO/modules/ps_facetedsearch/index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import type {ModulePsFacetesearchMainPageInterface} from '@interfaces/BO/modules/ps_facetedsearch/index';
import type {ModulePsFacetedSearchMainPageInterface} from '@interfaces/BO/modules/ps_facetedsearch/index';

@nesrineabdmouleh nesrineabdmouleh merged commit 8382306 into PrestaShop:main Jun 21, 2024
2 checks passed
@Progi1984 Progi1984 deleted the pages/BO/modules/psFacetedSearch branch June 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants