This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
[+] MO : Watermark : Show nonwatermarked image for logged in customers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //go through file formats defined for watermark and resize them | ||
| foreach ($this->imageTypes as $imageType) | ||
| { | ||
| $newFile = _PS_PROD_IMG_DIR_.$image->getExistingImgPath().'-'.stripslashes($imageType['name']).'.jpg'; | ||
| if (!ImageManager::resize($file, $newFile, (int)$imageType['width'], (int)$imageType['height'])) | ||
| $return = false; | ||
|
|
||
| $newFileOrg = _PS_PROD_IMG_DIR_.$image->getExistingImgPath().'-'.stripslashes($imageType['name']).'-'.Configuration::get('WATERMARK_HASH').'.jpg'; |
There was a problem hiding this comment.
HI,
Can you please use snake case for variables and not camel case ?
Thank you.
Regards
PhpMadman
force-pushed
the
WatermarkCustLogged
branch
from
b71385a
to
52eea67
Compare
gRoussac
added a commit
that referenced
this pull request
Nov 19, 2014
[+] MO : Watermark : Show nonwatermarked image for logged in customers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1
This allows customer that are logged to see the images without watermark.
To prevent users to just add something like -nonwatermark to the path. I added a hash at install and at hook execution if no hash exist.
The hash is permenent and not deleted at uninstall, allowing owners to re-install the module, and don't need to generate images again.
Part 2 - PrestaShop/PrestaShop#2063