This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Fix preston position #123
Merged
Fix preston position #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
commented
Aug 11, 2021
NeOMakinG
commented
| Questions | Answers |
|---|---|
| Description? | Preston on left was wrongly positionned |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#25527. |
| How to test? | Install the module and see if every steps are fine visually |
|
The problem is fixed with this PR without changing the css: #122 🤔 |
If you compare the Update bourbon PR, you can see on line 55 on tooltips.scss that there is a mistake, I think you had cache or something like this |
PierreRambaud
approved these changes
Aug 11, 2021
Progi1984
approved these changes
Aug 13, 2021
|
@hibatallahAouadni #122 is merged 😉 |
|
Hi @NeOMakinG, It is ok ✔️
https://drive.google.com/file/d/1R2fvyYY32fS-b6AgxO21gDDc2EvjkXj8/view?usp=sharing |
|
Thank you @NeOMakinG |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.