-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added travis + tests + cs fixes #24
Conversation
@@ -19,7 +19,7 @@ | |||
* needs please refer to http://www.prestashop.com for more information. | |||
* | |||
* @author PrestaShop SA <contact@prestashop.com> | |||
* @copyright 2007-2016 PrestaShop SA | |||
* @copyright 2007-2016 PrestaShop SA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2016?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I update this one I need to update all the others, I'd like to keep this pull request with one scope only
"scripts": { | ||
"cs-fix": "@php ./vendor/bin/php-cs-fixer fix .", | ||
"cs-fix-test": "@php ./vendor/bin/php-cs-fixer fix --dry-run --stop-on-violation --show-progress=dot .", | ||
"test": "SYMFONY_PHPUNIT_VERSION=5.7 php ./vendor/bin/simple-phpunit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting point here: passing env variables here make the special @php unavailable in Composer scripts. I don't know if it's intended or not.
@mickaelandrieu Wen being shipped to Addons as a downloadable PS module, do you know what process is performed ? I think there is at least 1
|
|
I don't think composer is called at all, that's why I don't use it to autoload module classes
We could, but how? I'm thinking about using
I don't know because I can't figure out why we have both |
|
I've switched to Thanks for the answers @Quetzacoalt91 ! |
Thanks @mickaelandrieu |
This contribution is about adding premises of a test suite and coding styles.
Also, a configuration for Travis.