Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter catalog page #51

Merged
merged 11 commits into from Oct 5, 2018
Merged

Filter catalog page #51

merged 11 commits into from Oct 5, 2018

Conversation

MrBaiame
Copy link
Contributor

No description provided.

@marionf
Copy link

marionf commented Sep 28, 2018

@MrBaiame

2 issues:

  • When I select a category, "Categories" is still displayed instead of the name of the category selected
  • When I select a category and enter something in the search bar, it should search and display results of modules that are only in the selected category

capture d ecran_355

It works on the core:

capture d ecran_354

@marionf
Copy link

marionf commented Sep 28, 2018

@MrBaiame

When I select "Other" category, I have no results.
I should have 6

capture d ecran_356

@MrBaiame
Copy link
Contributor Author

MrBaiame commented Oct 5, 2018

Should be fixed now, ping @marionf

@marionf marionf mentioned this pull request Oct 5, 2018
Closed
@PierreRambaud PierreRambaud merged commit 836b1dc into master Oct 5, 2018
@PierreRambaud
Copy link
Contributor

Thanks @MrBaiame

@PierreRambaud PierreRambaud deleted the filter_catalog_page branch October 5, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrBaiame @marionf @PierreRambaud