refacto: feature option provider getOptions method

PrestaShopCorp · Apr 25, 2024 · e7967b1 · e7967b1
1 parent d04e770
commit e7967b1
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/classes/ProductFilter/Options/FeatureOptionsProvider.php b/classes/ProductFilter/Options/FeatureOptionsProvider.php
@@ -49,21 +49,18 @@ public function getOptions(): array
 
         $options = [];
         foreach ($rawData as $rawAttribute) {
-            // find existing attribute group to modify it...
-            foreach ($options as $option) {
-                if ($option['id'] === $rawAttribute['id_feature']) {
-                    $option['values'][] = [
-                        'id' => $rawAttribute['id_feature_value'],
-                        'key' => $rawAttribute['feature_name'],
-                        'value' => $rawAttribute['value'],
-                        'language' => $this->languageRepository->getIsoById($rawAttribute['id_lang']),
-                    ];
-                    continue 2;
-                }
+            if (isset($options[$rawAttribute['id_feature']])) {
+                $options[$rawAttribute['id_feature']]['values'][] = [
+                    'id' => $rawAttribute['id_feature_value'],
+                    // Repeat key to ease the creation of payload when value is selected
+                    'key' => $rawAttribute['feature_name'],
+                    'value' => $rawAttribute['value'],
+                    'language' => $this->languageRepository->getIsoById($rawAttribute['id_lang']),
+                ];
+                continue;
             }
 
-            // ... or push a new one
-            $options[] = [
+            $options[$rawAttribute['id_feature']] = [
                 'id' => $rawAttribute['id_feature'],
                 'key' => $rawAttribute['feature_name'],
                 'values' => [
@@ -78,6 +75,6 @@ public function getOptions(): array
             ];
         }
 
-        return $options;
+        return array_values($options);
     }
 }