Added Delete functionality #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presto412
reviewed
Oct 4, 2020
| } | ||
| }); | ||
| } | ||
| function Delete(hash) { |
There was a problem hiding this comment.
Can be renamed to lowercase delete
Presto412
requested changes
Oct 4, 2020
| ); | ||
| if (possiblePresentFile.length !== 0) { | ||
| try { | ||
| fs.unlinkSync(possiblePresentFile[0].path + fileDetails.name); |
There was a problem hiding this comment.
What we'd like to do, is delete the file clusterwide. So it would make sense if you can make async delete API calls to the rest of the servers and remove it from the map, and then store it.
Presto412
requested changes
Oct 4, 2020
| success: function (response) { | ||
| console.log("sresponse", response); | ||
| document.getElementById("delete").innerHTML = | ||
| "<p>" + response.url + "</p>"; |
There was a problem hiding this comment.
response.url will be empty, so you can update this to rather display the message
|
Please reassign |
|
You're assigned to this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the code for the added Delete Functionality.
Thank you