New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-86554 #607

Closed
wants to merge 153 commits into
base: master
from

Conversation

Projects
None yet
@brianchandotcom

brianchandotcom commented Oct 23, 2018

No description provided.

brianchiu and others added some commits Oct 19, 2018

LPS-86079 In case of fatal failure, the framework may never initializ…
…e and stay null causing NPE to suppress the real failure.
LPS-86079 org.apache.aries.jax.rs.whiteboard has a floating snapshot …
…dependency to org.apache.aries.javax.jax.rs-api which breaks local build, fixing it to the lastest timestamp build.
@liferay-continuous-integration

This comment has been minimized.

Collaborator

liferay-continuous-integration commented Oct 23, 2018

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianchandotcom

This comment has been minimized.

brianchandotcom commented Oct 23, 2018

@Preston-Crary can you review this pull I got from brianchandotcom#64440

It seems like AssetDisplayContributorFieldTrackerImpl is unnecessary OSGi component creation.. please review pull. Thx!

@ealonso

This comment has been minimized.

ealonso commented Oct 25, 2018

Just started reviewing :)

:octocat: Sent from GH.

@jkappler

This comment has been minimized.

jkappler commented Oct 25, 2018

Hi @Preston-Crary, we changed so that no component is used, you can check it out here brianchandotcom#64545. Thanks!

@jkappler

This comment has been minimized.

jkappler commented Oct 25, 2018

ci:close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment