Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-86554 #607

Conversation

brianchandotcom
Copy link

No description provided.

brianchiu and others added 30 commits October 22, 2018 19:11
…e and stay null causing NPE to suppress the real failure.
…dependency to org.apache.aries.javax.jax.rs-api which breaks local build, fixing it to the lastest timestamp build.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianchandotcom
Copy link
Author

@Preston-Crary can you review this pull I got from brianchandotcom#64440

It seems like AssetDisplayContributorFieldTrackerImpl is unnecessary OSGi component creation.. please review pull. Thx!

@ealonso
Copy link

ealonso commented Oct 25, 2018

Just started reviewing :)

:octocat: Sent from GH.

@jkappler
Copy link

jkappler commented Oct 25, 2018

Hi @Preston-Crary, we changed so that no component is used, you can check it out here brianchandotcom#64545. Thanks!

@jkappler
Copy link

ci:close

@brianchandotcom brianchandotcom deleted the pull-request-64440-LPS-86554 branch October 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet