-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juxtaposition patches, SSL patch, CIA building, code.bin decompressing guide, and more #12
Conversation
Update pretendo branch before preparing merge
Update README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am by no means an expert when it comes to the 3DS, let alone it's patches. So this review covers more general things besides the patch source itself
For that, I would like to call upon @shutterbug2000, @ashquarky, @DaniElectra, and @Stary2001 since they know far more about the 3DS and it's patches than I do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments here and there, also giving some solutions to issues shown by Jon
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
…update gitignore to have something related to the decompression script, and updated ssl submodule (i think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Huge PR that changes pretty much everything but the app itself, it may compile for me, but it probably needs some further testing before getting merged (if it gets merged at all).
The Juxt patches and SSL patches are binary equivalent to the previously distributed ones to my knowledge, so that shouldn't be a probably AFAIK.
The branch this PR is from changes some readme links to one pointing to the PretendoNetwork github instead of mine for the PR, so if anyone wants to use the links, you should probably go to the main branch or just open the files from the file view.