Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juxtaposition patches, SSL patch, CIA building, code.bin decompressing guide, and more #12

Merged
merged 38 commits into from
Jul 6, 2023
Merged

Conversation

TraceEntertains
Copy link

Huge PR that changes pretty much everything but the app itself, it may compile for me, but it probably needs some further testing before getting merged (if it gets merged at all).

The Juxt patches and SSL patches are binary equivalent to the previously distributed ones to my knowledge, so that shouldn't be a probably AFAIK.

The branch this PR is from changes some readme links to one pointing to the PretendoNetwork github instead of mine for the PR, so if anyone wants to use the links, you should probably go to the main branch or just open the files from the file view.

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am by no means an expert when it comes to the 3DS, let alone it's patches. So this review covers more general things besides the patch source itself

For that, I would like to call upon @shutterbug2000, @ashquarky, @DaniElectra, and @Stary2001 since they know far more about the 3DS and it's patches than I do

DECOMPRESSING.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
app/Makefile Show resolved Hide resolved
app/meta/nimbus-cia.rsf Outdated Show resolved Hide resolved
app/meta/nimbus-cia.rsf Outdated Show resolved Hide resolved
patches/juxt/juxt-prod.pem Outdated Show resolved Hide resolved
patches/juxt/rootca.der Outdated Show resolved Hide resolved
patches/ssl/LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@DaniElectra DaniElectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here and there, also giving some solutions to issues shown by Jon

patches/juxt/juxt-prod.pem Outdated Show resolved Hide resolved
patches/juxt/rootca.der Outdated Show resolved Hide resolved
app/Makefile Outdated Show resolved Hide resolved
app/Makefile Outdated Show resolved Hide resolved
DECOMPRESSING.md Outdated Show resolved Hide resolved
app/meta/nimbus-cia.rsf Outdated Show resolved Hide resolved
app/meta/nimbus-cia.rsf Outdated Show resolved Hide resolved
TraceEntertains and others added 9 commits July 1, 2023 17:14
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
Co-authored-by: Daniel López Guimaraes <112760654+DaniElectra@users.noreply.github.com>
…update gitignore to have something related to the decompression script, and updated ssl submodule (i think)
Copy link
Member

@DaniElectra DaniElectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jonbarrow jonbarrow merged commit 2f10aef into PretendoNetwork:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants