patches/act: Fix crash with no accounts #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ACT patch changes a function with counts the number of accounts of the system to always report 1 account. If there are no accounts, such as on a system format or on a fresh Citra instance, this would make the sysmodule try to read from non-existent data. We replace the patch to allow the sysmodule to enter the counting loop, but only once. After finishing the loop, we jump out of it to the end and return the count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ACT patch changes a function with counts the number of accounts of the system to always report 1 account. If there are no accounts, such as on a system format or on a fresh Citra instance, this would make the sysmodule try to read from non-existent data.
We replace the patch to allow the sysmodule to enter the counting loop, but only once. After finishing the loop, we jump out of it to the end and return the count.