Nimbus 1.6.0 (the app part) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobimic887
approved these changes
Apr 7, 2024
DaniElectra
reviewed
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta loveeeeeee refactoring code!!!!!!!!!!!! (/s)
This skips the luma checks when citra is being used (which the other pr should have done but conflicting changes are no good)
It also uses nasc environment rather than account id for checks now (because I was very dumb when I originally worked on nimbus and thought account id directly correlated to nasc environment)
On top of that, i split more stuff into their own files because having singular megafiles looks kinda ugly ngl