Updates to AIOFab and UpgradedVehicles for BelowZero #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIOFabricator: implemented GetGameObjectAsync; no other modifications appear to be required, although LoadImageFiles was added to OnFinishedPatching as well as OnStartedPatching to deal with intermittent oddities. CustomBatteries: more BelowZero modifications - GameObject modification was moved to its own method to minimise code duplication; GetGameObject() and GetGameObjectAsync() load the required prefab in their way, then pass control to ModifyPrefab(), which performs the modifications common to both versions. UpgradedVehicles *) Updated to work with BelowZero, including Seatruck *) Implemented an API in the form of multiple public static methods in VehicleUpgrader to allow third-party mods to plug in to UpgradedVehicles; AddEfficiencyBonus(): registers a TechType as one that modifies engine efficiency; a value of 1f is equal to the VehiclePowerUpgradeModule. AddSpeedModifier(): registers a module as one that modifies vehicle speed. 1f provides a bonus equal to the Speed Module. efficiencyValue is the amount by which the module reduces engine efficiency AddArmourModule(): registers module as one that reduces vehicle damage. AddDepthModule(): registers module as a depth module. This does not actually modify depth limit; perhaps for a future version?
| _exosuitBonusSpeedMultiplier = upgradeOptions.ExosuitBonusSpeedMultiplier; | ||
| } | ||
|
|
||
| // Original values from the Vehicle class | ||
| private const float BaseSeamothSpeed = 11.5f; | ||
| #if SUBNAUTICA |
| } | ||
|
|
||
| if (IsSeamoth) | ||
| #if SUBNAUTICA |
| v.onGroundForceMultiplier = this.SpeedMultiplier * BaseExosuitWalkSpeed; | ||
| ErrorMessage.AddMessage($"Prawn Suit Land Speed: {v.onGroundForceMultiplier}m/s ({this.SpeedMultiplier * 100f:00}%)"); | ||
|
|
||
| } |
There was a problem hiding this comment.
hrmmm isnt the hoverbike a vehicle?? maybe if we are adding BZ support we should do something for it here?
There was a problem hiding this comment.
also I think sn1 has custom vehicles now that might benefit from some cross mod support?
PrimeSonic
reviewed
Feb 17, 2022
| @@ -40,6 +42,7 @@ public AiOFab() | |||
| "Multi-fuction fabricator capable of synthesizing most blueprints.") | |||
| { | |||
| OnStartedPatching += LoadImageFiles; | |||
| OnFinishedPatching += LoadImageFiles; | |||
There was a problem hiding this comment.
Do we really need to run the LoadImageFiles routine twice?
Would it be enough to only run on the OnFinishedPatching event?
UpgradedVehicles *) Reinstated some blocks which had been locked out to SN1-only *) Renamed VehicleUpgrader.EfficientyBonus to EfficiencyBonus
AiOFab.cs was changed to remove redundant image file loading UpgradedVehicles: *) Removed the "optional" part from efficiencyModifier argument in AddSpeedModifier method; adding a speed modifier *must* include an efficiency modifier. 0 remains a valid value, however. SpeedBooster.cs was modified to accommodate this change. *) Minor modification to VehicleUpgrader.CalculateDepthModuleIndex(); there is no functional difference at present, but this will be used in a future update to allow for other vehicles to be registered. *) VehicleUpgrader.GetEfficiencyPentalty() was renamed to GetEfficiencyPenalty *) Fixed a bug whereby speed modules would only be counted once, regardless of how many were equipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIOFabricator: implemented GetGameObjectAsync; no other modifications appear to be required, although LoadImageFiles was added to OnFinishedPatching as well as OnStartedPatching to deal with intermittent oddities.
CustomBatteries: more BelowZero modifications - GameObject modification was moved to its own method to minimise code duplication; GetGameObject() and GetGameObjectAsync() load the required prefab in their way, then pass control to ModifyPrefab(), which performs the modifications common to both versions.
UpgradedVehicles
*) Updated to work with BelowZero, including Seatruck
*) Implemented an API in the form of multiple public static methods in VehicleUpgrader to allow third-party mods to plug in to UpgradedVehicles;
AddEfficiencyBonus(): registers a TechType as one that modifies engine efficiency; a value of 1f is equal to the VehiclePowerUpgradeModule.
AddSpeedModifier(): registers a module as one that modifies vehicle speed. 1f provides a bonus equal to the Speed Module. efficiencyValue is the amount by which the module reduces engine efficiency
AddArmourModule(): registers module as one that reduces vehicle damage.
AddDepthModule(): registers module as a depth module. This does not actually modify depth limit; perhaps for a future version?