Fix read byte chunks #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface `Reader` allows simultaneous usage of both cnt and error in the result. ReadByteChunks now correctly handles the EOF situation when some bytes were returned simultaneously.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 83.58% 83.62% +0.04%
==========================================
Files 30 30
Lines 1066 1069 +3
==========================================
+ Hits 891 894 +3
- Misses 155 156 +1
+ Partials 20 19 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface
Readerallows simultaneous usage of both cnt and error in the result.ReadByteChunksnow correctly handles the situation when some bytes were returned simultaneously with an error/EOF.