Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 404 and 500 error page images #422

Closed
rlskoeser opened this issue Aug 30, 2023 · 4 comments
Closed

update 404 and 500 error page images #422

rlskoeser opened this issue Aug 30, 2023 · 4 comments
Assignees
Labels

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 30, 2023

testing instructions

please review the updated 404 and 500 error pages and let me know any concerns

@rlskoeser rlskoeser self-assigned this Aug 30, 2023
rlskoeser added a commit that referenced this issue Aug 30, 2023
@cvansant
Copy link

Quick question: With the 404 page, I can still see all the menu items at the top of the page. With the 500 page, I can't. Is that normal?
Screen Shot 2023-08-30 at 8 59 45 PM

Screen Shot 2023-08-30 at 9 00 31 PM

@rlskoeser
Copy link
Contributor Author

@cvansant very observant! Yes, that is expected behavior - a 500 error means something unexpected went wrong, and you don't want to run the risk of anything else going wrong when you serve out the error page, so it's intentional simplified and omits the logic for generating the menus.

@cvansant
Copy link

cvansant commented Sep 1, 2023

@rlskoeser Also noting that it has the "subscribe to the newsletter" button and the menu items at the bottom of the page. As long as that's okay, I think they look fine!

@rlskoeser
Copy link
Contributor Author

thanks @cvansant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants