Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want footnotes to indicate when a digital edition is available so that I can see and filter on records with and without transcription in the admin interface. #1001

Closed
7 tasks done
rlskoeser opened this issue Aug 3, 2022 · 2 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 3, 2022

testing notes

dev notes

  • update the footnote model to remove the interim content field and add a new boolean has_transcription (replaces the existing property)
  • add a signal handler that listens to annotation save events and updates the footnote appropriately when new transcriptions are added or all transcriptions are removed
  • update admin list views, filters, etc as needed
@blms blms self-assigned this Aug 5, 2022
blms added a commit that referenced this issue Aug 5, 2022
blms added a commit that referenced this issue Aug 8, 2022
blms added a commit that referenced this issue Aug 10, 2022
Also unregister post_delete signal from handler. ref #1001
blms added a commit that referenced this issue Aug 10, 2022
blms added a commit that referenced this issue Aug 15, 2022
blms added a commit that referenced this issue Aug 15, 2022
blms added a commit that referenced this issue Aug 15, 2022
blms added a commit that referenced this issue Aug 15, 2022
blms added a commit that referenced this issue Aug 16, 2022
blms added a commit that referenced this issue Aug 16, 2022
blms added a commit that referenced this issue Aug 16, 2022
blms added a commit that referenced this issue Aug 17, 2022
@gissoo gissoo changed the title As a content editor, I want footnotes to indicate when a digital edition is available so that I can see and filter on records with and without transcription in the admin intefrace. As a content editor, I want footnotes to indicate when a digital edition is available so that I can see and filter on records with and without transcription in the admin interface. Aug 22, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Aug 29, 2022
@kseniaryzhova
Copy link

@rlskoeser There is no log entry created when we added and saved a new transcription (https://test-geniza.cdh.princeton.edu/admin/corpus/document/19696/change/). The transcription itself was saved and displayed correctly, and a footnote labelled "digital edition" was created.

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova ah, sorry! my testing instructions were vague, there should be a log entry for the footnote, not on the document

@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants