Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a transcription editor, I want to reorder transcription blocks within a page so that I can make sure text content matches logical document order. #1021

Closed
11 tasks done
rlskoeser opened this issue Aug 22, 2022 · 7 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 22, 2022

testing notes (QA)

Log in as an admin. On a document with images, and with or without transcriptions (try both!) visit the document details page and add or edit a transcription.

  • Reorder the existing transcription text blocks in the right column by dragging and dropping, within one page
  • Try the same with new transcription text blocks (create by making a selection on the page image in the left column)
  • Delete a block and confirm the order remains correct
  • Refresh and confirm the order remains correct

dev notes

  • add drag/drop handle ability to annotation blocks (per Slack, handle discarded in favor of draggable blocks)
  • implement drag/drop behavior to reorder blocks within a page
  • after drag/drop completes, update position attribute on all annotations and save them if changed
    • position attribute should be 1-indexed schema:position
    • only save changed ones, if possible
  • order tahqiq blocks by position attribute on load
  • on create new annotation (when saving), set its position attribute to the last index + 1 (or, if it's the first one, position 1)
    • saving should reload annotation list, as always, and thus display new annotation in the correct position
  • disable drag-and-drop when any TinyMCE editor is open
  • disable drag-and-drop during saving/loading
@blms
Copy link
Contributor

blms commented Sep 8, 2022

This took longer than expected due to edge cases of handling a new annotation and annotation deletion, and needing to keep storage in sync with the frontend. Bumping the estimate to 5.

blms added a commit that referenced this issue Sep 8, 2022
Bump tahqiq commit hash, style drop zone (#1021, #1022)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 9, 2022
@kseniaryzhova
Copy link

@rlskoeser my transcription editor is launching very slowly - it takes several minutes for existing transcriptions to appear. Microsoft Edge, PC.

@kseniaryzhova
Copy link

kseniaryzhova commented Sep 9, 2022

@rlskoeser I cannot rearrange blocks which are not adjacent to each other in the transcription editor. For example, if I cannot move the first block below the third block in this screenshot - only below the second.
image
I think this will be crucial for rearranging joins with lots of text blocks.

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova would you test this in a browser other than Edge to see if it's something specific to Edge or if you have the same problem in other browsers?

FYI I think the slowness is some image processing I'm running on the test server, LMK if you want me to pause it while you're testing.

@kseniaryzhova
Copy link

@rlskoeser The issue above is fixed in Chrome. I tested over the weekend so hopefully nothing was running and it still sometimes takes minutes for existing transcriptions to appear in th edit window. For example, I'll click edit and wait for several minutes without it appearing. Once I refresh, it appears immediately.

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova I was running more image tiling over the weekend because it's going to take a while to get through all the images. Is this issue acceptable?

If you didn't accept because of the slowness, coordinate with me on slack and I can pause the image processing while you're testing.

@kseniaryzhova
Copy link

@rlskoeser once we paused tiling everything worked quickly!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants