Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want database translation fields for Hebrew and Arabic content in the admin site to render text RTL, so that I can read and edit the content properly. #1036

Closed
4 tasks done
richmanrachel opened this issue Aug 24, 2022 · 6 comments
Assignees

Comments

@richmanrachel
Copy link

richmanrachel commented Aug 24, 2022

testing notes

Test RTL alignment for Hebrew and Arabic text inputs in the following places in django admin:
(may require a hard refresh to load the new styles)

  • document type name and label
  • document description
  • scholarship record source title
  • scholarship record creator first and last name

Describe the bug
When adding Hebrew/Arabic content for a document description, the text stays in a left-adjusted format and therefore it is difficult to add proper punctuation at the end of a line.

To reproduce
Steps to reproduce the behavior:

  1. Go to admin site
  2. Click on a document
  3. Try to add Hebrew or Arabic descriptive text (ex. PGPID 8962)
  4. See error

Expected behavior
Text box automatically adjusts to RTL format when Hebrew/Arabic is typed or pasted in.

Screenshots
image

Device information

  • Device: MacBook Air
  • OS and version: macOS 12.0.1
  • Browser and version: Chrome 104.0.5112.101
  • Site version 4.7.0
@mrustow
Copy link

mrustow commented Oct 12, 2022

I only tested document description, and it was still justified left. I didn't understand document type name and label — should I be inputting a new type, but in He or Ar?

@rlskoeser rlskoeser removed the 🐛 bug Something isn't working label Oct 12, 2022
@rlskoeser rlskoeser changed the title Admin input not automatically adjusting to RTL text As a content editor, I want database translation fields for Hebrew and Arabic content in the admin site to render text RTL, so that I can read and edit the content properly. Oct 12, 2022
@kseniaryzhova
Copy link

@rlskoeser still not RTL in Hebrew or Arabic for the document types
image
image

@kseniaryzhova
Copy link

@rlskoeser tried to add new creator and source title in Arabic and Hebrew - still justified left as well. (Same with document descriptions)

@rlskoeser
Copy link
Contributor

@kseniaryzhova could you do a hard refresh just to be sure you're getting the new styles? And let me know what browser you're testing, in case that matters.

@kseniaryzhova
Copy link

@rlskoeser I'm on Chrome (PC), and the hard refresh doesn't change anything

@kseniaryzhova
Copy link

@rlskoeser testing on the test admin, it all works with a few hard refreshes!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants