-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update annotation controller so deep zoom doesn't autoscroll the page when in edit mode #1037
Comments
@blms what if instead of enabling zoom on page load we activate it based on intersection observer? |
@rlskoeser That makes sense to me! |
@rlskoeser It does not immediately autoscroll to the bottom BUT it's still not immediately showing me the existing transcription. I have to refresh again after clicking on th Edit transcription button. Are you still tiling? Let me know how you want to proceed - the slow load time seems like a separate issue so happy to close this one and write a new bug report. |
@kseniaryzhova Yes, if this one is working then please close and create a new bug report for the slow load time. It might be (and this is my hunch) that they are not loading at all rather than loading slowly. |
@rlskoeser works for us! |
testing notes (QA)
When navigating to the transcription editor for a document (QA public site document details page --> "edit X's transcription"/"add a new transcription", visible when logged into admin):
dev notes
at minimum, we should disable the autoscroll behavior needed for the image+transcription panel viewer
if possible, it would be great if we could do some lazy-loading, maybe only initialize zoom and annotation editing when images are visible?
The text was updated successfully, but these errors were encountered: