Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update annotation controller so deep zoom doesn't autoscroll the page when in edit mode #1037

Closed
1 task done
rlskoeser opened this issue Aug 25, 2022 · 5 comments
Closed
1 task done
Assignees
Labels
🛠️ chore One-off task or update

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 25, 2022

testing notes (QA)

When navigating to the transcription editor for a document (QA public site document details page --> "edit X's transcription"/"add a new transcription", visible when logged into admin):

  • Confirm that the page does not immediately scroll itself down to the last image on the document

dev notes

at minimum, we should disable the autoscroll behavior needed for the image+transcription panel viewer

if possible, it would be great if we could do some lazy-loading, maybe only initialize zoom and annotation editing when images are visible?

@rlskoeser
Copy link
Contributor Author

@blms what if instead of enabling zoom on page load we activate it based on intersection observer?
https://stimulus-use.github.io/stimulus-use/#/use-intersection

@blms
Copy link
Contributor

blms commented Aug 30, 2022

@rlskoeser That makes sense to me!

blms added a commit that referenced this issue Sep 2, 2022
blms added a commit that referenced this issue Sep 2, 2022
blms added a commit that referenced this issue Sep 7, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 14, 2022
@kseniaryzhova
Copy link

@rlskoeser It does not immediately autoscroll to the bottom BUT it's still not immediately showing me the existing transcription. I have to refresh again after clicking on th Edit transcription button. Are you still tiling? Let me know how you want to proceed - the slow load time seems like a separate issue so happy to close this one and write a new bug report.

@blms
Copy link
Contributor

blms commented Sep 19, 2022

@kseniaryzhova Yes, if this one is working then please close and create a new bug report for the slow load time. It might be (and this is my hunch) that they are not loading at all rather than loading slowly.

@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Sep 19, 2022
@kseniaryzhova
Copy link

@rlskoeser works for us!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

3 participants