Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a transcription editor I want to edit and rearrange transcription content as numbered lists so that I can correct line wrapping introduced to match printed editions. #1038

Closed
8 tasks done
rlskoeser opened this issue Aug 25, 2022 · 11 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 25, 2022

testing notes

  • TEI to html conversion should preserve line numbers from the TEI (unnumbered lines are being converted to paragraphs; lines are converted to ordered lists; line numbers starting with something other than 1 are converted to order list with a start attribute)
  • in the transcription editor, the lines should display and be editable as a regular ordered list
  • test editing a wrapped unnumbered line to clean up the formatting (here's one example: https://test-geniza.cdh.princeton.edu/en/documents/646/transcribe/228/ )

dev notes

  • revise tei to html conversion to generate ordered lists (with start attributes when needed) so they can be edited in TinyMCE (done as part of tei to annotation conversion)
  • revise list styles for transcription to remove counter and display the actual marker element from the ordered list

revisions after testing:

  • update public image+transcription viewer margins to handle new list styles
    • display full number two-digit numbers
    • when scrolling to second transcription, numbers should not show on the left
    • style unnumbered paragraphs between lines so they aren't as jarring
blms added a commit that referenced this issue Aug 29, 2022
Revise ordered list style to use actual line numbers (#1038)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Aug 29, 2022
@kseniaryzhova
Copy link

kseniaryzhova commented Aug 29, 2022

@rlskoeser @richmanrachel and I get the second number cut off in lines that have more than 1 digit - so we just see a bunch of 1s and 2s for lines in the 10s and 20s. This problem goes away in the transcription editor, but on the public site when it's just displaying the transcription, this is what we see.
image
https://test-geniza.cdh.princeton.edu/en/documents/646/

@kseniaryzhova
Copy link

@rlskoeser we're not seeing the unnumbered line for the document you linked (the one of which I took a screenshot above). What should we do?

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova I meant the text between lines 3 and 4 and between lines 19 and 20

@richmanrachel
Copy link

@rlskoeser - it looks like the editor itself is handling the wrap text correctly (here's the same doc as in Ksenia's pic above):
image
I agree that it looks a little funny on the viewer side to not have parts of the same line indented.

@richmanrachel
Copy link

Line numbers are not showing up in the search results anymore (which was a really useful feature so I knew where in the document to look):
image

@richmanrachel
Copy link

I'm not quite sure how to test the first and third point, but I think things are working... This doc has a mixture of numbered lines and margins without line numbers and it looks good: https://test-geniza.cdh.princeton.edu/en/documents/3874/

@rlskoeser rlskoeser added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Aug 30, 2022
@rlskoeser
Copy link
Contributor Author

@richmanrachel I want to make sure I'm understanding your comment here correctly:

it looks like the editor itself is handling the wrap text correctly

What I understand is that you were able to edit and correct the wrapped lines fine in the editor, but you would like us to improve the display of the migrated version so the unnumbered lines don't stick out as much. Is that right?

@richmanrachel
Copy link

What I understand is that you were able to edit and correct the wrapped lines fine in the editor, but you would like us to improve the display of the migrated version so the unnumbered lines don't stick out as much. Is that right?

@rlskoeser - yes, that's right!

@rlskoeser
Copy link
Contributor Author

@blms would you also adjust the styles so paragraphs in transcription match the indentation and spacing of lines of text? (ideally only paragraphs between lines; we could set a class on the <p> when we migrate if that would help)

@blms
Copy link
Contributor

blms commented Aug 30, 2022

@rlskoeser I'll try with CSS sibling selectors first and let you know if it will need a class.

@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 1, 2022
@richmanrachel
Copy link

This looks better - closing!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants