-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a transcription editor I want to edit and rearrange transcription content as numbered lists so that I can correct line wrapping introduced to match printed editions. #1038
Comments
Revise ordered list style to use actual line numbers (#1038)
@rlskoeser @richmanrachel and I get the second number cut off in lines that have more than 1 digit - so we just see a bunch of 1s and 2s for lines in the 10s and 20s. This problem goes away in the transcription editor, but on the public site when it's just displaying the transcription, this is what we see. |
@rlskoeser we're not seeing the unnumbered line for the document you linked (the one of which I took a screenshot above). What should we do? |
@kseniaryzhova I meant the text between lines 3 and 4 and between lines 19 and 20 |
@rlskoeser - it looks like the editor itself is handling the wrap text correctly (here's the same doc as in Ksenia's pic above): |
I'm not quite sure how to test the first and third point, but I think things are working... This doc has a mixture of numbered lines and margins without line numbers and it looks good: https://test-geniza.cdh.princeton.edu/en/documents/3874/ |
@richmanrachel I want to make sure I'm understanding your comment here correctly:
What I understand is that you were able to edit and correct the wrapped lines fine in the editor, but you would like us to improve the display of the migrated version so the unnumbered lines don't stick out as much. Is that right? |
…wrap Transcription line number margin for 2 digits (#1038)
@rlskoeser - yes, that's right! |
@blms would you also adjust the styles so paragraphs in transcription match the indentation and spacing of lines of text? (ideally only paragraphs between lines; we could set a class on the |
@rlskoeser I'll try with CSS sibling selectors first and let you know if it will need a class. |
This looks better - closing! |
testing notes
dev notes
revisions after testing:
The text was updated successfully, but these errors were encountered: