Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression on server error for documents associated with Heidelberg IIIF (PGPIDs 34016, 34017, 34018) #1046

Closed
rlskoeser opened this issue Aug 30, 2022 · 5 comments
Labels
🚫 wontfix This will not be worked on

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 30, 2022

We seem to have a regression on #906 — we fixed this before, but it's broken again now. Getting a 500 error in production and staging both.

Based on the nginx logs in staging, there's a problem with getting the preferred label for the license (but could be the license uri itself that we're doing something wrong with)

https://test-geniza.cdh.princeton.edu/en/documents/34016/
https://test-geniza.cdh.princeton.edu/en/documents/34017/
https://test-geniza.cdh.princeton.edu/en/documents/34018/

@rlskoeser rlskoeser added the 🐛 bug Something isn't working label Aug 30, 2022
@rlskoeser
Copy link
Contributor Author

Looks like an rdflib change — no error running locally with 6.0, error in staging with 6.2, when I upgrade I can duplicate the problem. I don't see it in the rdflib changelog anywhere, but the preferredLabel doesn't seem to be available anymore. Need to update djiffy. (But we can pin rdflib to <6.2 in the meantime as a quick fix.)

@kseniaryzhova
Copy link

@rlskoeser Rachel and I tested these PGPIDs in production and they load just fine, can we close?

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova they work because I have a temporary fix in place, but I still need to fix it properly — hope to address as part of the eventual work to upgrade to django 4

@richmanrachel
Copy link

@rlskoeser - the images are working. Is this the temporary fix or part of the permanent upgrade? https://geniza.princeton.edu/en/documents/34016/

@rlskoeser
Copy link
Contributor Author

This specific issue was resolved by specifying the version of the rfdlib library; I think it's ok to close this issue and figure out how to address that problem as part of maintenance +upgrades

@rlskoeser rlskoeser added 🚫 wontfix This will not be worked on and removed 🐛 bug Something isn't working labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants