-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a content editor, I want transcription formatting preserved in search result display but ignored for search text so that I can see where in the transcription matching terms are. #1049
Comments
ok! I wondered if it might not be sufficient, but wanted to know for sure before doing more work. Now that we're using proper ordered lists, we don't have the sequence number on each line by default, so we'll have to do a little bit of extra work to put it in so we can display it on the search version. |
Okay, thanks so much! Also, just an oddity that's happening now with the formatting for results that are too far into the text for line numbers - there's a first line and then an indentation: |
@rlskoeser transcriptions which have numbered lines on the public site do not have them on the admin site. None of the documents with transcriptions on the public site (I've clicked through about 10) have numbered transcription lines. |
ah, good catch, we forgot to update some styles in admin that are suppressing the numbers |
Refactor organization: move class out of models, use utility function ref #1049
…-lines Add line numbers to transcription lines in indexed html (#1049)
@rlskoeser transcription keywords in context do not display the line number when the match is from the middle of the text - I took the following example from the middle of line 10 but the correct line number does not appear in the search results (for the same document): |
@kseniaryzhova Could you comment with the PGPID and the search query you used so I can test this and try to figure out why it's wrong? Thanks! |
@blms sorry I only just saw this! It's PGPID 1223 and I used the name "הנכבד בן כגק" |
@rlskoeser works for me! |
testing notes
dev notes
ol > li
and use "start" attribute if presentli
, doesn't matter whichThe text was updated successfully, but these errors were encountered: