Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I want to cut and paste transcription content from a Google Doc or similar and have it display properly with site styles so that I can easily add existing transcription content. #1055

Closed
2 tasks done
rlskoeser opened this issue Sep 1, 2022 · 4 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Sep 1, 2022

testing notes (qa)

In the transcription editor for a document (QA public site document details page --> "edit X's transcription"/"add a new transcription", visible when logged into admin):

  • Edit or create a transcription block. Paste in some content with formatting, such as bold, italic, tables, images, etc numbered list (such as the unpublished edition by Marina in the scholarship records for PGPID 646). Click "save" and confirm the extraneous formatting is removed, but list numbering remains.

dev notes

  • use bleach or similar to sanitize body html content on Annotation.save (maybe make use of a clean method? but make sure it's called on save)

PGPID 646 is a good test case, there's an unpublished edition by Marina in a google doc linked in an existing footnote; cutting and pasting from the google doc looks like it works, but when I tried it, it introduced a bunch of in-line styles.

@blms blms self-assigned this Sep 12, 2022
blms added a commit that referenced this issue Sep 12, 2022
blms added a commit that referenced this issue Sep 12, 2022
blms added a commit that referenced this issue Sep 13, 2022
Also bump tahqiq commit hash (#1055)
blms added a commit that referenced this issue Sep 13, 2022
blms added a commit that referenced this issue Sep 13, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 14, 2022
@kseniaryzhova
Copy link

@rlskoeser extraneous formatting is removed and the list numbering remains BUT the numbers move to the ends of the lines like so:
image

@blms
Copy link
Contributor

blms commented Sep 19, 2022

@kseniaryzhova Odd, that suggests the list formatting got stripped out. Can you pass along the source that you copied from? I want to see how it's structured to see if there's anything we can do to preserve the list formatting.

@rlskoeser
Copy link
Contributor Author

@kseniaryzhova was it formatted as a numbered list in the version you copied from, or were the numbers just text?

@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Sep 19, 2022
@kseniaryzhova
Copy link

@rlskoeser works for me - other issues discussed on Slack!

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants