Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-to-left site design implementation revisions #1127

Closed
19 tasks done
blms opened this issue Sep 27, 2022 · 2 comments
Closed
19 tasks done

Right-to-left site design implementation revisions #1127

blms opened this issue Sep 27, 2022 · 2 comments
Assignees
@blms
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Sep 27, 2022 •
edited

qa checklist

  • Misaligned "color bars" for metadata
  • Content pages list bullets/numbers on wrong side
  • Issue with short labels in nav
  • ITT panel transcription content hidden
  • Missing space between ITT panel toggles
  • Wrong spacing for collapsed ITT panel toggles
  • Wrong spacing for image header label and controls
  • Image header label partially offscreen on mobile
  • Backwards zoom slider track coloration
  • Wrong spacing for permalink

Remaining issues in RTL site:
@blms blms added the 🛠️ chore One-off task or update label Sep 27, 2022
@blms blms self-assigned this Sep 27, 2022
blms added a commit that referenced this issue Sep 28, 2022
@blms
Fix misaligned RTL metadata color bars (#1127)
6f6a884
blms added a commit that referenced this issue Sep 28, 2022
@blms
Fix permalink in RTL (#1127)
80d36ad
blms added a commit that referenced this issue Sep 28, 2022
@blms
Revise ITT panel spacing in RTL (#1127)
dbed7da
blms added a commit that referenced this issue Oct 3, 2022
@blms
Move general RTL style from Hebrew-specific blocks
a058ad4 
ref #1127
blms added a commit that referenced this issue Oct 3, 2022
@blms
Add tweaks for lists in content pages (#1127)
b467542
blms added a commit that referenced this issue Oct 4, 2022
@blms
Fix issue with short labels in nav (#1127)
29a39db
@blms blms mentioned this issue Oct 4, 2022
Merged
@blms blms added the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Oct 6, 2022
@blms
Copy link
Contributor Author

blms commented Oct 6, 2022 •
edited

Some issues remain:

  • Transcriptions still not showing up in RTL even when they do in LTR. The content of the div is just completely empty so it seems it's failing to get the annotations.
  • The image header label somehow is still left-aligned, so it's wrongly spaced on desktop and partially offscreen on mobile. (Thought I'd fixed that!)

blms added a commit that referenced this issue Oct 6, 2022
@blms
Fix h2 alignment in img header (#1127)
ecb2589
blms added a commit that referenced this issue Oct 6, 2022
@blms
Merge pull request #1168 from Princeton-CDH/feature/1127-rtl-headerfix
8a30ed7 
Fix h2 alignment in img header (#1127)
@blms blms removed the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Oct 6, 2022
@blms
Copy link
Contributor Author

blms commented Oct 6, 2022

All confirmed fixed in QA

@blms blms closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

Labels
🛠️ chore One-off task or update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blms