Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt IIIF URLs from i18n patterns #1164

Closed
blms opened this issue Oct 6, 2022 · 2 comments
Closed

Exempt IIIF URLs from i18n patterns #1164

blms opened this issue Oct 6, 2022 · 2 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Oct 6, 2022

maybe we need to define separately and include in our main urls.py differently? might mean the urls will have a different namespace, but once we get the url config right I think everything else should work

Originally posted by @rlskoeser on Slack

@blms blms added the 🛠️ chore One-off task or update label Oct 6, 2022
@blms blms self-assigned this Oct 6, 2022
blms added a commit that referenced this issue Oct 6, 2022
blms added a commit that referenced this issue Oct 6, 2022
blms added a commit that referenced this issue Oct 6, 2022
blms added a commit that referenced this issue Oct 6, 2022
@rlskoeser
Copy link
Contributor

@blms I checked an annotation created by the tei migration after this fix was pushed to the test site, and the document and source uris in the annotation both look good to me. Is there any other checking you want to do on this?

@blms
Copy link
Contributor Author

blms commented Oct 6, 2022

@rlskoeser Great, thanks! I also just checked the /iiif/annotations/ endpoints for a few documents with transcriptions and they all look fine. I think we're good to close.

@blms blms closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

2 participants