Transcriptions are failing to save in the editor

[blms]

Testing notes (QA)

In the transcription editor for a document:

• Create and save a new annotation and confirm it persists in the editor
• Edit and save an existing annotation and confirm the change persists in the editor
• Delete an existing annotation and confirm it is deleted successfully

dev notes

• Fix save failure condition
• raise events on save/delete failure
• raise events on save/delete success
• display errors/success messages in frontend

[blms]

About to jump into a meeting, so before I forget: I think the save failure is another Annotorious/async race condition.

First we await the Annotorious promise, which raises an event. Our event handler awaits saving the annotation to storage.

Back in the original function, we fetch all annotations from storage after the Annotorious promise resolves.

But there's no guarantee that our event handler has itself resolved. It's entirely possible (and indeed, it appears to be the case) that we are calling this.storage.loadAnnotations() before the annotation has finished saving to the storage. Should be as simple as calling that method in storage.ts handleUpdateAnnotation instead.

[kseniaryzhova]

@rlskoeser works for me, thank you!