Clicking outside the current annotation zone and/or into another zone in the transcription editor cancels unsaved changes without warning

[blms]

testing notes

in the transcription editor on the QA site

• select an existing transcription, don't make any changes, then click on the image outside the selected zone; it should do nothing
• select an existing transcription, don't make any changes, then click the "Cancel" button; it should cancel without prompting
• on a record with multiple transcription boxes on the same image, select one for editing; if you click on the other transcription text box by the same image, nothing should happen — you should still be editing the same transcription
• select an existing transcription, make some changes to the text content, then click on the image outside the selected zone; it should do nothing
• select an existing transcription, make some changes to the text content, then click the "Cancel" button; it should prompt you to confirm if you want to cancel
• when you are prompted, if you choose to cancel, it should cancel and editor should no longer be active
• when you are prompted, if you want to keep editing, it should keep the editor open; confirm you can save your changes
• create a new transcription block
  • confirm there's no issue with drawing or resizing the box, making it larger and smaller
  • confirm clicking on anything outside of the box on the image, such as another annotation or the image itself, does nothing
  • enter some content, click the "cancel" button, and confirm you're prompted to confirm the cancel
  • when you are prompted, if you choose to cancel, it should cancel and editor should no longer be active
  • when you are prompted, if you want to keep editing, it should keep the editor open; confirm you can save your changes
• while editing a transcription block, create or edit one on another image on the same document. confirm you can have both open at the same time, and edit and save them independently of each other.

old testing notes

testing notes

in the transcription editor

• select an existing transcription, don't make any changes, then click on the image outside the selected zone; it should cancel without prompting
• select an existing transcription, don't make any changes, click on the page outside the editor, hit escape; it should cancel without prompting
• on a record with multiple transcription boxes on the same image, select one for editing; if you click on the other transcription text box by the same image, nothing should happen — you should still be editing the same transcription
• select an existing transcription, make some changes to the text content, click on the page outside the editor, hit escape; it should prompt you to confirm if you want to cancel
• select an existing transcription, make some changes to the text content, then click on the image outside the selected zone; it should prompt you to confirm if you want to cancel
• when you are prompted, if you choose to cancel, it should cancel and editor should no longer be active
• when you are prompted, if you want to keep editing, it should keep the editor open; confirm you can save your changes

dev notes

• prompt the user before cancelling

[rlskoeser]

@mrustow @kseniaryzhova I have work in progress to prompt you before canceling the active annotation you are editing if there are changes in the text editor. Ben raised a question when he reviewed the changes: would you also want to be prompted like this when you click the "cancel" button? Or can we assume if you cancel by clicking the button you want to discard any changes you've made?

[kseniaryzhova]

@rlskoeser My instinct is that yes, we also would like to be prompted when clicking the "cancel" button, just in case it was accidental.

[rlskoeser]

Ok, thanks.

[kseniaryzhova]

@rlskoeser @blms when I click outside the annotation box on the image, it does bring up the "do you want to continue editing?" window and if I say ok, then it keeps the transcription editor open BUT then I can no longer save my changes. If I hit save it just gives me the "saving..." popup but doesn't actually close the transcription editor NOR does it save my changes (when I finally hit refresh). This does not happen when I click outside the editor page and hit escape, I'm able to successfully save changes then,

[blms]

@kseniaryzhova Ah—@rlskoeser that sounds like the same behavior I was experiencing before in Princeton-CDH/annotorious-tahqiq#27 (comment). Here's my video of it:

existing.anno.mov

[kseniaryzhova]

@rlskoeser @blms I think I like this one better - no switching between text boxes. However, when I clicked on an annotation box in the same document but on a different page (the verso), it switched immediately to the box I clicked on.

[kseniaryzhova]

@blms works great, and thanks especially for the notes you wrote! I want to run this by Marina to see if this is an acceptable exchange for the auto save. I think it is, but we'll see what she thinks!

[richmanrachel]

The test site is redirecting to the production site again! So I thought it wasn't working until I looked back at the urls.... It is in fact working for me on the test site :)

[blms]

Glad to hear it's working! Going to go ahead and close this one based on the above feedback and add the "question" tag to the autosave one.